Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with code indented with tabs #8

Open
zachhardesty7 opened this issue Dec 2, 2020 · 2 comments
Open

Fails with code indented with tabs #8

zachhardesty7 opened this issue Dec 2, 2020 · 2 comments

Comments

@zachhardesty7
Copy link
Contributor

The extension unfortunately has issues with regex parsing tabs for checking consistent indentation. Pretty much everything I tried failed, but if you'd like a simple case, this will cause an error.

	status: STATUS.SUCCESS
@bfintal
Copy link

bfintal commented Oct 11, 2022

I was confused as to why my first try to convert didn't work. It appears that clearing all my indentation then converting works.

@zachhardesty7
Copy link
Contributor Author

@bfintal I fixed the tabs issue in this open PR #27. Since this repo appears abandoned, I published the fixed extension to the marketplace. May add some other enhancements in the future (like making it less picky about indentation).

https://marketplace.visualstudio.com/items?itemName=zachhardesty.convert-object-to-jsx-vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants