Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vue-cli@5 #228

Open
ZachJW34 opened this issue Mar 26, 2022 · 11 comments
Open

Support vue-cli@5 #228

ZachJW34 opened this issue Mar 26, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@ZachJW34
Copy link
Owner

vue-cli@5 is stable now and @nx-plus/vue should drop support of vue-cli@4 and switch to 5.

@hloehrmann
Copy link

+1, would be nice because vue-cli depends on some older versions of autoprefixer which in the end depends on postcss 7 and I need postcss 8 to upgrade from Tailwind 2 to 3.

@marimendez88
Copy link

This would be fantastic, have a couple of dependencies just waiting for vue-cli@5

@basti1253
Copy link
Contributor

Hi,
I've forked your fantastic repository and updated vue-cli to version 5. It looks like there's no more need to overwrite chalk colors at first glance. I've dropped custom cache directories as well. From a first impression it looks good enough, I didn't test it much tbh.
Please let me know if this looks good enough to open a PR discussion.
show diff

kind regards,
Sebastian

@ZachJW34
Copy link
Owner Author

@basti1253 Thanks for looking into this! I looked through your changes and they make sense so go ahead and open a PR. There are a few more deps I think we need to update so we are more in line with vue-cli but we can address those in the PR you open.

I'd like to create a migrations script as well so users get their deps bumped automatically but if you're not familiar with those I can follow that up once we get your changes in

@basti1253
Copy link
Contributor

basti1253 commented Jul 12, 2022

I'd like to create a migrations script as well so users get their deps bumped automatically but if you're not familiar with those I can follow that up once we get your changes in

Good catch. I'll take a look (hopefully on friday) and prepare the PR then. I've already update all dependencies locally when using babel,typescript and eslint.

@hallowatcher
Copy link

Hey guys, any updates on the PR?

@silvan88
Copy link

silvan88 commented Sep 28, 2022

@ZachJW34 @basti1253 can we expect this anytime soon?

@jotwea
Copy link

jotwea commented Oct 14, 2022

@basti1253 would help very much if you can find the time to prepare the PR, so @ZachJW34 can review and work on the migrations.

@ZachJW34
Copy link
Owner Author

ZachJW34 commented Dec 5, 2022

I have recently published @nx-plus/vue@15.0.0-rc.0 which now uses vue-cli v5 (webpack 5). I haven't published any docs/migrations yet but if you're curious you can try it out! It requires v15 of Nx.

I'm going to be working over the next week to write some docs and migrations so stay tuned!

@avxkim
Copy link

avxkim commented Mar 8, 2023

@ZachJW34 do you plan to update @nx-plus/nuxt as well?

@hloehrmann
Copy link

@ZachJW34 any update on the docs/migrations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants