Add&remove #2
Add&remove #2
Conversation
There was a problem hiding this comment.
Hi @ZahraArshia ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
TO HIGHLIGHT:
- Your project is professional 馃挴
- Your repo is professional 馃挴
- Well structured files 馃挴
Required Changes 鈾伙笍
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/CRUD.js
Outdated
| add() { | ||
| const temp = new Task(this.taskList.length, document.getElementById('inputDescription').value, false); | ||
| this.taskList.push(temp); | ||
| localStorage.setItem('taskList', JSON.stringify(this.taskList)); | ||
| this.taskList = JSON.parse(localStorage.getItem('taskList')); | ||
| this.update(); | ||
| location.reload(); | ||
| } |
There was a problem hiding this comment.
Please ensure that items are numbered from 1 according to the project requirement and NOT 0.
.
|
Hello; |
There was a problem hiding this comment.
Hi @ZahraArshia 馃憢,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 馃帀 馃帀 馃帀 馃帀 馃帀,
Cheers and Happy coding!馃憦馃憦馃憦
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello 馃槉
in this step of project:
in the feature:
the
clear all completedbutton is disable for now, in next step its functionality will be implemented according to Microverse schedule