Flags Enum Deserialization no longer works

[0x53A]

After updating Fable.Remoting to the latest version (which updated Fable.SimpleJson from 3.2 to 3.8), I can no longer deserialize a [<Flags>] enum with multiple bits set.

This worked before because it was just treated like an int.

I assume the issue is here: 83f12b8#diff-dd3f6f39b238e426d14aaeaf582f183cR128

For a correcter validation, it would need to check whether it has the FlagsAttribute, then check either each individual bit, or the whole thing.

But to be honest, my preference would be to drop the check, because in .NET you can do

enum E {  A = 1, B = 2 }
E e = (E)0xff;

[Zaid-Ajaj]

Hello @0x53A, sorry for introducing the regression, it looks like I didn't have a proper test for enums with flags. Do you have an example for me that fails so I can look at it? A PR would be even better yet 😄

my preference would be to drop the check

That is fine by me if it is the only way to fix this

it would need to check whether it has the FlagsAttribute, then check either each individual bit, or the whole thing.

We don't have access to attribute metadata in Fable :/

[0x53A]

Hi @Zaid-Ajaj I added a test here: #39

That is fine by me if it is the only way to fix this

I guess this is also a bit a philosophical question.

In .net you can assign "invalid" values to an enum (like in my example above), so the question is whether you want to detect such cases, constraining them more than .net normally does, or not.

[Zaid-Ajaj]

I guess it's alright in this case 😄 released v3.8.1 with the fix 🚀 thanks a lot for the PR. I will be able to patch Fable.Remoting.Client soon