-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for the type
attribute: omit it altogether
#108
Comments
I definitely agree that In summary, I have no idea what's best. When I feel that way I usually just try to follow as closely to what the user would expect as possible, in this case it would probably be |
The problem from my point of view is that without prefix this makes I have seen several people using |
Alright, stupid idea then hahah, thanks guys for the feedback 😄 |
The case seems closed, but for the record:
|
I would favor a better name while also keeping
|
IMHO the main problem with double backticks isn't related to familiarity; it's that they're fairly "noisy" (hence my suggestion for |
Right now we have used the enum
withType
to specify the type of the Htmlinput
elements as follows:The more I write it, the more weird it feels because
withType
is usually used the context of functions when chaining them using the|>
operator but here they are just enums.In the recharts binding, I took the liberty to experiment with the
type
attribute because some components likeLine
andArea
also have this property and I have chosen to omit it and use the value directly as a valid attribute for that chart in subject:Notice here the attribute
area.monotone
is actually short-hand fortype="monotone"
from the JS equivalent and I am happy with in, this is nice too for the native properties like that:Very short, you get used it quickly and doesn't feel weird. I would personally also like
props.types.password
but again that feels like too many key strokes...I was wondering what you guys think of it: @MangelMaxime, @cmeeren, @zanaptak, @Shmew
The text was updated successfully, but these errors were encountered: