Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(uniswap-v3): Show min/max ranges and fix sig figs on range #2528

Merged
merged 1 commit into from Apr 6, 2023
Merged

feat(uniswap-v3): Show min/max ranges and fix sig figs on range #2528

merged 1 commit into from Apr 6, 2023

Conversation

immasandwich
Copy link
Contributor

Description

This is ugly
image

This is better
image

Also, provide 4 significant digits for the range.

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

How to test?

pingu1
pingu1 approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@pingu1 pingu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid!

@immasandwich immasandwich merged commit a341f75 into main Apr 6, 2023
6 checks passed
@immasandwich immasandwich deleted the uniswap-v3-min-max-and-sig-figs-for-range branch April 6, 2023 15:18
@zapper-bot zapper-bot mentioned this pull request Apr 6, 2023
Merged
@SamIam-0x
Copy link
Contributor

This is beautiful

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pingu1 pingu1 pingu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@immasandwich @SamIam-0x @pingu1