feat(rigoblock): add uni v3 positions #2902
Conversation
- append null address to tracked assets - return base currency if positive balance as underlying token - return base currency balance reserve
- added abstract implementation of custom contract position fetcher - added supported chain files
- correct token definitions
- renamed imported type to allow removing of overwritten methods
- silenced undefined network warning for debugging
- since cannot override methods with different return types, injected uniswap position builder instead of inheriting uniswap position fetcher methods - implemented missing methods in rigoblock contract fetcher -removed commented code
- added tokens from liquidity positions in data props - implemented getTokenBalancesPerPosition method
- use contract position template instead of custom - implement getTokenBalancesPerPosition - rename getBalance method to getUnderlyingBalances
- added liquidity definition as sum of USD value of liquidity positions to add to tvl
| ]; | ||
| }); | ||
| }).flat(2); | ||
| } |
There was a problem hiding this comment.
I suggest you implement the logic fetching the underlying tokens in the getDefinitions since it's freee.
You can get the underlying token addresses by appTokens.map(x => x.tokens.map(y => y.address))
There was a problem hiding this comment.
This has been done. I do not later retrieve from appToken.tokens as would require an extra RPC call. I am storing the tokens and the balances by making the onchain calls in the definitions, then saving some data that is needed in the application in dataProps and reading them from there.
There was a problem hiding this comment.
I'm not sure I understand why you're fetching everything in the definition, propagating it all the way down to method which retrieve balances ?
There was a problem hiding this comment.
The getBalances method only accepts address: string as input (please correct me if I am wrong as I would be more than happy to pass contractPosition as input in getBalances using a custom contract position fetcher to save the rpc calls), so regardless of it being a contract position template or overwriting it with a custom contract position template the onchain call is required at that level. However, in order to define the liquidity positions owned by each rigoblock pool, I have to make the same onchain call, as with the same call both underlying liquidity position tokens and balances are returned.
There was a problem hiding this comment.
When doing a bunch of read with Multicall, there's almost no need to optimize the number of RPC calls. In getTokenDefinitions, you don't need to have the actual balances of a pool, all you need are token addresses. GetBalance has to return the balance for a specific wallet and not for a pool (I might be confused as I'm not familiar with rigoblock)
src/apps/rigoblock/common/rigoblock.pool.contract-position-fetcher.ts
Outdated
Show resolved
Hide resolved
src/apps/rigoblock/common/rigoblock.pool.contract-position-fetcher.ts
Outdated
Show resolved
Hide resolved
- use getUnderlyingBalances method in getDefinitions only - pass underlying token balances to data props - retrieve token balances per position from data props
| ]; | ||
| }); | ||
| }).flat(2); | ||
| } |
There was a problem hiding this comment.
I'm not sure I understand why you're fetching everything in the definition, propagating it all the way down to method which retrieve balances ?
Description
Added Rigoblock contract position fetcher for Uniswap V3 liquidity positions owned by Rigoblock pools. The contract positions are with the same group id as the token fetcher. This PR also adds base currency balances (i.e. ETH for Ethereum and so on).
Checklist
How to test?
run locally and check the returned values from http://localhost:5001/apps/rigoblock/positions?groupIds[]=pool&network=ethereum