Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

fix(position): Update tokenId's type to String #2903

Merged
merged 1 commit into from Aug 21, 2023
Merged

fix(position): Update tokenId's type to String #2903

merged 1 commit into from Aug 21, 2023

Conversation

wpoulin
Copy link
Contributor

@wpoulin wpoulin commented Aug 18, 2023 •
edited

Description

  • tokenId?: number => tokenId?: string

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

How to test?

immasandwich
immasandwich approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@immasandwich immasandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be some changes required in Zapper API after this is merged too

@wpoulin wpoulin merged commit 86e103a into main Aug 21, 2023
11 checks passed
@wpoulin wpoulin deleted the update-tokenId-to-string branch August 21, 2023 20:39
@zapper-bot zapper-bot mentioned this pull request Aug 21, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@immasandwich immasandwich immasandwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wpoulin @immasandwich