Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat: adds support for base network #2905

Merged
merged 9 commits into from Aug 23, 2023

Conversation

meetkosiso
Copy link
Contributor

Description

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

How to test?

@wpoulin
Copy link
Contributor

wpoulin commented Aug 21, 2023

Could you not delete the pnpm-lock file 🙏

@meetkosiso
Copy link
Contributor Author

Could you not delete the pnpm-lock file 🙏

Not deleting the pnpm-lock file is failing the build checks. I tried severally not to delete the file and on each occasion, the build test failed after committing.

@wpoulin wpoulin self-requested a review August 21, 2023 19:02
Copy link
Contributor

@wpoulin wpoulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has to be something wrong with your pnpm-lock.yaml. Have you tried hard resetting the file to master's version

@meetkosiso
Copy link
Contributor Author

There has to be something wrong with your pnpm-lock.yaml. Have you tried hard resetting the file to master's version

Yes, I tried resetting it from the master, same experience, and also I did not add any new dependency, I only pull the latest changes that contains some new dependencies and did pnpm install to install the dependency and when I committed my changes, the commit is failing because of pnpm-lock.yaml.

@wpoulin
Copy link
Contributor

wpoulin commented Aug 21, 2023

Initially, I think there was something wrong with your fork as CI never ran on the PRs you opened on Studio. I always had to merge without waiting for requirements (aka skip CI steps )
Have you considered deleting and forking again making sure everything is up to date ?

@meetkosiso
Copy link
Contributor Author

Initially, I think there was something wrong with your fork as CI never ran on the PRs you opened on Studio. I always had to merge without waiting for requirements (aka skip CI steps ) Have you considered deleting and forking again making sure everything is up to date ?

I have fixed the pnp-lock file issue and it ran successfully on the CI. Thanks.

@wpoulin wpoulin self-requested a review August 22, 2023 21:13
@wpoulin
Copy link
Contributor

wpoulin commented Aug 22, 2023

Adding remote upstream, get the latest changes from the upstream to your branch and push. This will resolve the issue This branch is out-of-date with the base branch

@meetkosiso
Copy link
Contributor Author

Adding remote upstream, get the latest changes from the upstream to your branch, and push. This will resolve the issue This branch is out-of-date with the base branch

Thanks @wpoulin, yes I'm adding upstream, this issue was because of I had a different version of pnpm. Could you review and possibly merge? Thanks.

@wpoulin
Copy link
Contributor

wpoulin commented Aug 23, 2023

Well done, BINGO !!!!

@wpoulin wpoulin merged commit 6ce85e4 into Zapper-fi:main Aug 23, 2023
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants