This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
fix(curve): add cadc/usdc pool and farm #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immasandwich
reviewed
May 8, 2022
alexandresobolevski
force-pushed
the
alexandre-sobolevski-add-curve-cadc-usdc-pool
branch
from
55fefa1
to
31176e4
Compare
immasandwich
approved these changes
May 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would like to see my cadc/usdc curve position: https://curve.fi/factory-crypto/12
This PR adds the relevant pool and gauge farm. It includes a very minor refactor in the ethereum farm position fetcher: to use the app definition governance token address (CRV) as reward address instead of a hard coded address for CRV.
Checklist
How to test?
Make sure the farm is found and built properly (search the result for CADC)
GET http://localhost:5001/apps/curve/positions?groupIds[]=farmMake sure the balance is accurate
GET http://localhost:5001/apps/curve/balances?addresses[]=0x2BA829474AC766261633375eE002B2B75e775FdB