feat(app): add Mean Finance integration #753
feat(app): add Mean Finance integration #753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please prefix the contracts in mean-finance/contracts/abis
with mean-finance
, i.e.: mean-finance-hub.json
.
This will make it easier to find files in this repo as it continues to grow!
id: 'mean-finance', | ||
name: 'Mean Finance', | ||
description: | ||
'Our protocol enables users to Dollar Cost Average (DCA) any ERC20 into any ERC20 with their preferred period frequency.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove "our". The description should not be from the perspective of the protocol contributor, but rather as a third party. i.e.: "Mean Finance enables users to ..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, but are you able to create contract positions for this protocol? i.e.: is there a contract that serves as the entrypoint for funds into your DCA positions?
If so, its better to have it listed via a ContractPositionFetcher since that will enable us to calculate TVL, determine the number of users in your protocol, etc.
OK I see that Mean Finance maintains positions via NFT tokens deposited through the DCA Hub. You can create a You don't need to use this ContractPosition in the balance fetcher, but this will enable Zapper to perform the optimizations mentioned earlier, and also enable us to calculate the TVL of Mean Finance for a neat upcoming feature. |
3e80d50
to
4c169ed
Compare
@immasandwich thank you for the review! All is up to date now |
Description
Adds Mean Finance integration with its DCA Positions. Mean Finance is the state-of-the-art DCA open protocol that enables users (or dapps) to Dollar Cost Average (DCA) any ERC20 into any ERC20 with their preferred period frequency, without sacrificing decentralization or giving up personal information to any centralized parties. We do all of this by leveraging both Chainlink and Uniswap V3 TWAP oracles.
More info on our docs
Checklist
How to test?
http://localhost:5001/apps/mean-finance/balances?addresses[]=0x7AfB052ae7B80aAc6e559281cC261089738b66F6&network=polygon
http://localhost:5001/apps/mean-finance/balances?addresses[]=0xf488aaf75D987cC30a84A2c3b6dA72bd17A0a555&network=optimism
Can add more addresses if needed :)