Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat: add steakhut #890

Merged
merged 7 commits into from
Jul 19, 2022
Merged

feat: add steakhut #890

merged 7 commits into from
Jul 19, 2022

Conversation

tonzgao
Copy link
Contributor

@tonzgao tonzgao commented Jul 17, 2022

Description

https://discord.com/channels/647279669388771329/964569348243075082/997934589920170024
Convex clone for TradeJoe on Avax

Notes:

  • not affiliated with project
  • needs hjoe as base token. I could probably add it as a vault token but its not directly convertible due to locking mechanics
  • not sure if having cvxcrv and cvx staking in the same contract position file is correct or if they need to be separated
  • i noticed the autogenerator has every group with type GroupType.TOKEN now?
  • docs and website are a little inconsistent regarding contracts. assuming that only v2 staking contracts need to be supported

Checklist

How to test?

http://localhost:5001/apps/steak-hut/positions?network=avalanche&groupIds%5B%5D=staking&groupIds%5B%5D=pool

note: i dont use avax, so i couldnt really test this directly. here's a random address i used to test with:
http://localhost:5001/apps/steak-hut/balances?network=avalanche&addresses%5B%5D=0x56cf215429fdcA3FB344927942cd1Ed7427e7D9C

@tonzgao tonzgao changed the title Steakhut feat: add steakhut Jul 17, 2022
@immasandwich
Copy link
Contributor

Hey @tonzgao , we have a limitation right now in that BaseTokens can only be added if they exist on CoinGecko (this sucks, and we'll want to change this soon).

For now, it'll be better to add hJOE as a token group part of Steakhut. It looks like hJOE is minted 1:1 to JOE, so you can consider the price of hJOE as the price of JOE (see https://snowtrace.io/tx/0x3ce028fc52d719ee6f96da3159fd264745bc7213e8ead964307169dd5fc73a14)

@immasandwich
Copy link
Contributor

As for your comments:

  1. Perfectly fine to have the staking positions for hJOE and STEAK in the same fetcher since they follow the same interface
  2. A bug on our side, we'll make sure to fix this. I've mentioned that you should change the group type in your definitions accordingly.
  3. Perfectly fine to support just V2 since I'm assuming they want to kill off V1 with time anyway.

@immasandwich immasandwich merged commit 570c51a into Zapper-fi:main Jul 19, 2022
volt62 pushed a commit to volt62/zapper-studio that referenced this pull request Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants