Advanced search in Teambuilder #1133
Conversation
js/client-teambuilder.js
Outdated
| @@ -2570,6 +2584,13 @@ | |||
| } | |||
| this.chartSet(val, selectNext); | |||
| }, | |||
| searchChange: function (e) { | |||
| //91 for right CMD / 93 for left / CMD 17 for CTL | |||
| if (e.keyCode != 91 && e.keyCode != 93 && e.keyCode != 17) { | |||
There was a problem hiding this comment.
Can use !== here as (iirc) the type will always be number
There was a problem hiding this comment.
Thanks for the feedback! I'll update the PR when I'm home
|
;_; I keep on having these refactors being submitted when I'm in the middle of rewriting the client in React... |
|
I actually love this but also merging it in is going to be hell... |
|
I read about the refactor in the comments, I mostly did this to get a familiar with the project. I won’t be offended if you dont merge this lol. I am more excited to work on the new client when it arrives :D |
This looks pretty mergeable. |
|
In hindsight, yeah. There's no reason not to merge. |
|
@littlefoot22 - do you have a Smogon username that you'd like to have tagged when I post the user-visible changelog to the update thread after the next server restart? |
@scheibo |
Really like this project and want to contribute so I took a shot at one of the items on the new develops issue.
Please let me know if this is on the right track / feedback / what to add / is this still needed?
Supports search on / Pokémon / ability / item / move / anything in unpacked team: