Implement /unblacklistall command #2800
Conversation
panpawn
force-pushed
the
patch-182
branch
2 times, most recently
from
0cdbdde
to
1629127
Compare
|
...who asked for this? I don't think this is a good idea... especially if used accidentally. |
| if (!target) { | ||
| user.lastCommand = '/unblacklistall'; | ||
| this.errorReply("THIS WILL UNBLACKLIST ALL BLACKLISTED USERS."); | ||
| this.errorReply("To confirm, use: /unblacklistall confirm"); |
There was a problem hiding this comment.
I don't think this is a good idea... especially if used accidentally.
This kind of prevents the "if used accidentally" scenario, for the most part
|
Also, I just think it might be helpful with rooms where the blacklists are rather large and if a room should want to remove them; same purpose for Also, I thought we were making roomban-type punishments closer to global ban punishments... There is an |
|
I intentionally didn't add this tbh
|
| }); | ||
| if (!success) return false; | ||
| Punishments.savePunishments(); | ||
| return success; |
There was a problem hiding this comment.
This should probably return the list of previously blacklisted users, which should be logged.
With that, the command becomes revertible and safe.
There was a problem hiding this comment.
Well, it's not completely revertible, unless you log IPs/alts, and even then there's not a good way to add IPs/alts to a blacklist.
panpawn
force-pushed
the
patch-182
branch
2 times, most recently
from
59b5331
to
07f3a63
Compare
|
Updated |
|
|
||
| let unblacklisted = Punishments.roomUnblacklistAll(room); | ||
| if (!unblacklisted) return this.errorReply("No users are currently blacklisted in this room to unblacklist."); | ||
| this.addModCommand("All blacklists in this room have been lifted by " + user.name + ". This has unblacklisted: " + unblacklisted.join(', ')); |
There was a problem hiding this comment.
Like this it will spam the room though.
Just log it with this.logEntry
|
Updated |
| if (!unblacklisted) return this.errorReply("No users are currently blacklisted in this room to unblacklist."); | ||
| let reply = `All blacklists in this room have been lifted by ${user.name}.`; | ||
| room.add(`|c|${user.getIdentity()}|/log ${reply}`).update(); | ||
| this.logEntry(`${reply} This has unblacklisted: ${unblacklisted.join(', ')}`); |
There was a problem hiding this comment.
There are two spaces here, but it's not a big deal
There was a problem hiding this comment.
Funny you mention that actually, I was taught to always put two spaces in-between sentences in school when I was learning how to type. I'll remove this though, now that I'm remembering this isn't a standard for PS stuff.
|
Updated |
| if (!unblacklisted) return this.errorReply("No users are currently blacklisted in this room to unblacklist."); | ||
| let reply = `All blacklists in this room have been lifted by ${user.name}.`; | ||
| room.add(`|c|${user.getIdentity()}|/log ${reply}`).update(); | ||
| this.logEntry(`${reply} This has unblacklisted: ${unblacklisted.join(', ')}`); |
There was a problem hiding this comment.
I think this is redundant with the room.add above. I think the ${reply} part can be safely removed.
There was a problem hiding this comment.
So, how are we mod-logging this then?
There was a problem hiding this comment.
The code I recommend here is:
this.addModCommand(`All blacklists in this room have been lifted by ${user.name}.`);
this.logEntry(`Unblacklisted users: ${unblacklisted.join(', ')}`);
The .update() is unnecessary; commands automatically update rooms.
| if (!unblacklisted) return this.errorReply("No users are currently blacklisted in this room to unblacklist."); | ||
| let reply = `All blacklists in this room have been lifted by ${user.name}.`; | ||
| room.add(`|c|${user.getIdentity()}|/log ${reply}`).update(); | ||
| this.logEntry(`${reply} This has unblacklisted: ${unblacklisted.join(', ')}`); |
There was a problem hiding this comment.
The code I recommend here is:
this.addModCommand(`All blacklists in this room have been lifted by ${user.name}.`);
this.logEntry(`Unblacklisted users: ${unblacklisted.join(', ')}`);
The .update() is unnecessary; commands automatically update rooms.
This also introduces Punishments#roomUnblacklistAll to do the heavy lifting of this command.
|
Updated |
|
I still think this is going to cause more problems than it solves, but I guess we can try it out and see. |
This also introduces Punishments#roomUnblacklistAll to do the heavy lifting of this command.