Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for viewing only punishment-related actions in the modlog #5535

Merged
merged 1 commit into from Jun 21, 2019

Conversation

scheibo
Copy link
Contributor

@scheibo scheibo commented Jun 11, 2019

Context: An option to split modlog into punishments and non punishments (3rd most popular)

  • I'm not wedded to the idea of a '/punishlog' command vs. implementing some sort of flag ('scope=punishments'?) the way maxLines works, but this was the easiest approach and its relatively simple to change
  • I may be missing or including actions which are or are not 'punishment related'. Something like 'NOTE' is not necessarily 'punishment-related', but it often provides additional context for punishments so I figured it was useful to include. Ditto some others I've added. On the main server we may wish to add to PUNISHMENTS with actions from private code, potentially meaning the list should be defined in config/ somewhere instead of here.
  • Taking a step back - would it instead make sense to have the non-punishment actions show up in different log files entirely? The approach I've taken here relies on the existing design, but I'm not positive trivia actions belong in the same place as global bans to begin with, even if both require auth.

@scheibo
Copy link
Contributor Author

scheibo commented Jun 11, 2019

@panpawn has brought up the fact that this depends on modlogs being uniformly formatted, @Zarel can you confirm that you've run @sparkychildcharlie's script from #3972?

@sparkyneko
Copy link
Contributor

sparkyneko commented Jun 11, 2019

pretty sure it hasnt been run, not that ive checked/able to check :x

@Zarel
Copy link
Member

Zarel commented Jun 13, 2019

I'm worried about how it'll work while the server is actively running...

@AustinXII
Copy link
Member

The script is missing battleban btw. Also perhaps try it on smogtours first?

@sparkyneko
Copy link
Contributor

Im pretty sure at the time i wrote it battleban didnt exist on the server... sooo it wouldnt been in sentence form

@AustinXII
Copy link
Member

@sparkychildcharlie yeah you did, I was just pointing it out incase zarel were to run it right now since no one has mentioned it to him

@panpawn
Copy link
Contributor

panpawn commented Jun 14, 2019

Shouldn't matter, since the script's purpose is to only convert entries before the standard formatting was changed, and it only targets ones that need to be converted

@scheibo
Copy link
Contributor Author

scheibo commented Jun 19, 2019

@Zarel - are you OK with this approach? I think this change can still land without the script having been run, it just will be more accurate/effective once that is run as well.

@Zarel
Copy link
Member

Zarel commented Jun 21, 2019

It's fine I guess.

@Zarel Zarel merged commit 85b6325 into smogon:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants