Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially incorrect comments in src/batch.rs #74

Closed
2 tasks
mpguerra opened this issue Mar 9, 2023 · 0 comments · Fixed by #75
Closed
2 tasks

Potentially incorrect comments in src/batch.rs #74

mpguerra opened this issue Mar 9, 2023 · 0 comments · Fixed by #75
Assignees
Labels
C-audit Category: Issues arising from audit findings

Comments

@mpguerra
Copy link

mpguerra commented Mar 9, 2023

Motivation

We want to track all of the findings from the zebra audit, no matter how minor.

Details

Some of the comments in src/batch.rs seem slightly off:

  • On line 146, the documentation of the verify() function includes a warning about outputs differing between batched and individual verifications; however, the whole point of ZIP 215 and the ed25519-zebra crate is indeed to ensure that batched and nonbatched verification always yield identical results on the same signatures.
  • On line 154, the described verification equation does not include the multiplication by the cofactor. Such an equation would indeed lead to differences between batched and non-batched outputs. Fortunately, the implementation itself includes the multiplication by the cofactor (line 214).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-audit Category: Issues arising from audit findings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants