Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement phase 2 for Participant (#123) #197

Merged
merged 5 commits into from May 17, 2024
Merged

Implement phase 2 for Participant (#123) #197

merged 5 commits into from May 17, 2024

Conversation

natalieesk
Copy link
Contributor

This closes #123

conradoplg
conradoplg requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, and it works! There is just some session_id handling that is redundant and can be removed, and a printing issue.

participant/src/cli.rs Outdated Show resolved Hide resolved
participant/src/cli.rs Outdated Show resolved Hide resolved
participant/src/comms.rs Outdated Show resolved Hide resolved
participant/src/comms/cli.rs Outdated Show resolved Hide resolved
participant/src/comms/http.rs Outdated Show resolved Hide resolved
participant/src/comms/http.rs Outdated Show resolved Hide resolved
conradoplg
conradoplg approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@conradoplg conradoplg merged commit 06c0c24 into main May 17, 2024
6 checks passed
@conradoplg conradoplg deleted the phase_2_participant_123 branch May 17, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Phase 2 of Participant operations for FROST for Zcash demos
2 participants
@natalieesk @conradoplg