Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alloc feature #28

Merged
merged 2 commits into from Sep 12, 2022
Merged

Conversation

krnak
Copy link
Contributor

@krnak krnak commented Jul 31, 2022

Problem

pasta_curves/alloc, which requires #[global_allocator], is not disabled on default-features=false

Solution

  • pasta_curves/alloc disabled by default
  • pasta_curves/alloc enabled in dev-dependencies

@krnak
Copy link
Contributor Author

krnak commented Sep 12, 2022

Hey @conradoplg, @dconnolly, could you merge this?

Cargo.toml Show resolved Hide resolved
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added a comment to make it clearer. Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #28 (2ad5801) into main (51b1519) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files          15       15           
  Lines        1154     1154           
=======================================
  Hits         1000     1000           
  Misses        154      154           

@conradoplg conradoplg merged commit 14d4622 into ZcashFoundation:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants