Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store Orchard nullifiers in the finalized state #1983

Closed
4 of 5 tasks
teor2345 opened this issue Apr 7, 2021 · 3 comments · Fixed by #2185
Closed
4 of 5 tasks

Store Orchard nullifiers in the finalized state #1983

teor2345 opened this issue Apr 7, 2021 · 3 comments · Fixed by #2185
Assignees
@oxarbitrage
Labels
A-consensus Area: Consensus rule updates A-infrastructure Area: Infrastructure changes C-design Category: Software design work C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks S-needs-design Status: Needs a design decision
Projects
🦓 Effort Affinity Grouping
Milestone
2021 Sprint 10

Comments

@teor2345
Copy link
Contributor

teor2345 commented Apr 7, 2021 •
edited by oxarbitrage

Is your feature request related to a problem? Please describe.

Transaction v5 introduces Orchard nullifiers, which we need to store in the finalized state.

Describe the solution you'd like

Describe alternatives you've considered

These changes are required for NU5.

Additional context

Nullifier sets are validated in #958.
@teor2345 teor2345 added C-design Category: Software design work A-consensus Area: Consensus rule updates S-needs-design Status: Needs a design decision C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage NU-5 Network Upgrade: NU5 specific tasks P-Medium labels Apr 7, 2021
@teor2345 teor2345 added this to the 2021 Sprint 9 milestone Apr 7, 2021
@teor2345 teor2345 added this to No Estimate in Effort Affinity Grouping via automation Apr 7, 2021
@teor2345 teor2345 added this to To Do in 🦓 via automation Apr 7, 2021
@teor2345 teor2345 moved this from No Estimate to XS - 2 in Effort Affinity Grouping Apr 7, 2021
@teor2345 teor2345 added the A-infrastructure Area: Infrastructure changes label Apr 12, 2021
@mpguerra mpguerra moved this from XS - 2 to S - 3 in Effort Affinity Grouping Apr 13, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Apr 13, 2021
@oxarbitrage oxarbitrage self-assigned this May 17, 2021
@oxarbitrage
Copy link
Contributor

This is blocked by #2116

@oxarbitrage oxarbitrage added S-blocked Status: Blocked on other tasks and removed S-blocked Status: Blocked on other tasks labels May 18, 2021
@oxarbitrage oxarbitrage mentioned this issue May 21, 2021
Merged
5 tasks
@oxarbitrage
Copy link
Contributor

I made a PR for this at #2185, i am unsure on how to do:

  • Rebuild the cached state for the integration CI tests

@teor2345
Copy link
Contributor Author

I made a PR for this at #2185, i am unsure on how to do:

  • Rebuild the cached state for the integration CI tests

@dconnolly can show you how to do this on the Zebra test cloud.

@mpguerra mpguerra linked a pull request May 24, 2021 that will close this issue
Store orchard nullifiers into the state #2185
Merged
5 tasks
@oxarbitrage oxarbitrage mentioned this issue May 25, 2021
Merged
🦓 automation moved this from To Do to Done Jun 1, 2021
Effort Affinity Grouping automation moved this from S - 3 to Done Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-consensus Area: Consensus rule updates A-infrastructure Area: Infrastructure changes C-design Category: Software design work C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks S-needs-design Status: Needs a design decision
Projects
No open projects
Effort Affinity Grouping
Done
🦓
  
Done
Milestone
2021 Sprint 10
Development

Successfully merging a pull request may close this issue.

Store orchard nullifiers into the state oxarbitrage/zebra
3 participants
@mpguerra @teor2345 @oxarbitrage