Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate tokio-console #2112

Closed
2 tasks
Tracked by #3322 ...
teor2345 opened this issue May 5, 2021 · 4 comments · Fixed by #4519
Closed
2 tasks
Tracked by #3322 ...

Integrate tokio-console #2112

teor2345 opened this issue May 5, 2021 · 4 comments · Fixed by #4519
Assignees
Labels
A-network Area: Network protocol updates or fixes C-security Category: Security issues I-hang A Zebra component stops responding to requests I-heavy Problems with excessive memory, disk, or CPU usage I-remote-node-overload Zebra can overload other nodes on the network

Comments

@teor2345
Copy link
Collaborator

teor2345 commented May 5, 2021

Scheduling

This ticket is only required if we've fixed all the known hang bugs in Zebra, and Zebra still has frequent hangs.

Is your feature request related to a problem? Please describe.

It's hard to see what tokio is doing inside Zebra.

another cool thing the console does now is its ⚠️warnings system. this is like a linter, but for your program’s runtime behavior. by monitoring the tasks in the application, we can detect behavior patterns that might indicate bugs or performance issues.

https://twitter.com/mycoliza/status/1471880880289366022

Describe the solution you'd like

Describe alternatives you've considered

Continue trying to debug tokio using metrics and other indirect methods

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Low I-usability Zebra is hard to understand or use labels May 5, 2021
@teor2345 teor2345 added this to No Estimate in Effort Affinity Grouping via automation May 5, 2021
@teor2345 teor2345 moved this from No Estimate to S - 3 in Effort Affinity Grouping May 5, 2021
@teor2345 teor2345 added this to To Do in 🦓 via automation May 5, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label May 11, 2021
@teor2345 teor2345 added A-network Area: Network protocol updates or fixes C-security Category: Security issues I-hang A Zebra component stops responding to requests I-heavy Problems with excessive memory, disk, or CPU usage I-remote-node-overload Zebra can overload other nodes on the network P-Medium and removed A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement P-Low I-usability Zebra is hard to understand or use labels Dec 19, 2021
@teor2345
Copy link
Collaborator Author

teor2345 commented Dec 19, 2021

I've marked this as a medium priority, because we still have hang and performance bugs in Zebra that are hard to diagnose and fix.

@teor2345 teor2345 changed the title Integrate TurboWish/tokio-console Integrate tokio-console Jan 5, 2022
@mpguerra mpguerra mentioned this issue Jan 26, 2022
40 tasks
@ftm1000
Copy link

ftm1000 commented Jan 26, 2022

redistributing issues that can be separately worked from this epic #2311

@teor2345
Copy link
Collaborator Author

teor2345 commented Mar 1, 2022

We don't need to do this unless there are some performance or hang issues we need to fix.

@teor2345
Copy link
Collaborator Author

Re-opening this ticket, because we might want to do it this sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-security Category: Security issues I-hang A Zebra component stops responding to requests I-heavy Problems with excessive memory, disk, or CPU usage I-remote-node-overload Zebra can overload other nodes on the network
Projects
No open projects
🦓
  
In progress
Development

Successfully merging a pull request may close this issue.

3 participants