Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant watch values once our Tokio dependency is updated #2573

Closed
jvff opened this issue Aug 5, 2021 · 1 comment
Closed

Remove redundant watch values once our Tokio dependency is updated #2573

jvff opened this issue Aug 5, 2021 · 1 comment
Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement
Projects

Comments

@jvff
Copy link
Contributor

jvff commented Aug 5, 2021

Motivation

When Zebra uses tokio::sync::watch::Sender, we sometimes need an extra value field, because Tokio version 0.3.6, doesn't have a watch::Sender::borrow method.

That method is available on Tokio 1.0.0, so once we update to the newer version we can remove that field and replace its usage with *self.sender.borrow().

Impacted types:

Related Work

#2200 tracks updating the Tokio dependency.

@jvff jvff added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Aug 5, 2021
@zfnd-bot zfnd-bot bot added this to To Do in 🦓 Aug 5, 2021
@mpguerra mpguerra added C-cleanup Category: This is a cleanup P-Low labels Aug 13, 2021
@teor2345 teor2345 changed the title Refactor zebra_state::service::BestTipHeight once our Tokio dependency is updated Remove redundant watch values once our Tokio dependency is updated Aug 26, 2021
@teor2345
Copy link
Collaborator

teor2345 commented Jun 2, 2022

We can fix this when we change the related code.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement
Projects
No open projects
🦓
  
To Do
Development

No branches or pull requests

3 participants