Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of authorizing data commitment #2632

Closed
conradoplg opened this issue Aug 13, 2021 · 1 comment
Closed

Improve performance of authorizing data commitment #2632

conradoplg opened this issue Aug 13, 2021 · 1 comment
Labels
C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness
Projects

Comments

@conradoplg
Copy link
Contributor

Motivation

#2547 implements the authorizing data commitment specified in ZIP-244 which is the root of a Merkle tree of the auth digest of each transaction. (zebra-chain/src/block/merkle.rs, FromIterator for AuthDataRoot)

This tree is padded with leaves containing all-zeroes hashes to make the tree full. However that can be expensive.

We can either optimize that by pre-computing the roots of of fully-"empty" subtrees and using that (like note commitment trees do), or by making sure this is only computed once for each block and reused where needed.

Specifications

Designs

Related Work

Follow up to #2547

@conradoplg conradoplg added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Aug 13, 2021
@zfnd-bot zfnd-bot bot added this to To Do in 🦓 Aug 13, 2021
@teor2345 teor2345 added the P-Low label Oct 13, 2021
@conradoplg conradoplg added the I-slow Problems with performance or responsiveness label Mar 15, 2022
@teor2345
Copy link
Contributor

teor2345 commented Jun 2, 2022

We can re-open this if it turns up in CPU profiles.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness
Projects
No open projects
🦓
  
To Do
Development

No branches or pull requests

3 participants