Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop panicking if a connection has multiple failures #3109

Closed
1 task done
teor2345 opened this issue Nov 28, 2021 · 1 comment · Fixed by #3200
Closed
1 task done

Stop panicking if a connection has multiple failures #3109

teor2345 opened this issue Nov 28, 2021 · 1 comment · Fixed by #3200
Assignees
@teor2345
Labels
A-network Area: Network protocol updates or fixes C-bug Category: This is a bug I-panic Zebra panics with an internal error message I-usability Zebra is hard to understand or use
Projects
🦓
Milestone
2021 Sprint 25 - ...

Comments

@teor2345
Copy link
Collaborator

teor2345 commented Nov 28, 2021 •
edited
Loading

Motivation

Currently, Zebra panics if a connection has multiple failures.

In #1610, we describe a complicated refactor that would stop Zebra having multiple failures on the same connection. But this refactor could introduce other bugs.

There's a much simpler solution that avoids the panics.

Suggested Solution

  • if multiple errors happen, log an info-level message instead of panicking

Rejected Solutions

  • close both the inbound and outbound channels in fail_with
    • check how those closed channels are eventually handled (they should not panic, debug logs are ok)
    • closing a sink is an async operation, because it flushes, so we should just drop it
    • generic streams can't be closed

Related Work

We'll remove some kinds of connection errors in #2107

This ticket obsoletes #1610
@teor2345 teor2345 added C-bug Category: This is a bug S-needs-triage Status: A bug report needs triage P-Medium I-panic Zebra panics with an internal error message I-usability Zebra is hard to understand or use A-network Area: Network protocol updates or fixes labels Nov 28, 2021
@zfnd-bot zfnd-bot bot added this to To Do in 🦓 Nov 28, 2021
@teor2345 teor2345 mentioned this issue Nov 28, 2021
Closed
3 tasks
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn

@teor2345 teor2345 mentioned this issue Dec 14, 2021
Merged
3 tasks
@teor2345 teor2345 self-assigned this Dec 14, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Dec 15, 2021
🦓 automation moved this from To Do to Done Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-network Area: Network protocol updates or fixes C-bug Category: This is a bug I-panic Zebra panics with an internal error message I-usability Zebra is hard to understand or use
Projects
No open projects
🦓
  
Done
Milestone
2021 Sprint 25 - Last Sprint of 2021
Development

Successfully merging a pull request may close this issue.

Stop ignoring some connection errors that could make the peer set hang ZcashFoundation/zebra
2 participants
@mpguerra @teor2345