Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(scan): Scan the first 10 blocks with the ZECpages viewing key #7903

Closed
oxarbitrage opened this issue Nov 3, 2023 · 2 comments · Fixed by #7916
Closed

test(scan): Scan the first 10 blocks with the ZECpages viewing key #7903

oxarbitrage opened this issue Nov 3, 2023 · 2 comments · Fixed by #7916
Assignees
@oxarbitrage
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests S-needs-triage Status: A bug report needs triage

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Nov 3, 2023 •
edited
Loading

As part of the block scanner proof of concept we want to scan the first 10 blocks of the blockchain for the zecpages viewing key. While we do not anticipate finding any related transactions, this process is important for converting a string into a sapling key that is compatible with the ECC crate's scanning function.

The code available at #7812 may be useful for this task.

This is all test code by now, convertion code could be moved to zebra-chain in a later ticket if decided.

This task is a smaller component of a larger issue .

Completition of this and the merge of #7758 will close #7727
This was referenced Nov 3, 2023
Closed
Open
@oxarbitrage oxarbitrage added the A-blockchain-scanner Area: Blockchain scanner of shielded transactions label Nov 3, 2023
@mpguerra mpguerra added S-needs-triage Status: A bug report needs triage C-testing Category: These are tests P-Medium ⚡ labels Nov 6, 2023
@oxarbitrage oxarbitrage self-assigned this Nov 6, 2023
@oxarbitrage oxarbitrage changed the title test: Scan a populated_state() for the zecpages viewing key test: Scan a populated_state() for the ZECpages viewing key Nov 6, 2023
@oxarbitrage oxarbitrage mentioned this issue Nov 6, 2023
Merged
3 tasks
@mpguerra mpguerra linked a pull request Nov 7, 2023 that will close this issue
poc(scanner): add a populated state test for ZECpages viewing key #7916
Merged
3 tasks
@mpguerra
Copy link
Contributor

mpguerra commented Nov 7, 2023

Hey team! Please add your planning poker estimate with Zenhub @arya2 @oxarbitrage @teor2345 @upbqdn

@teor2345
Copy link
Contributor

teor2345 commented Nov 7, 2023

Just to be clear, this is the first 10 blocks, not the entire cached state.

@teor2345 teor2345 changed the title test: Scan a populated_state() for the ZECpages viewing key test: Scan the first 10 blocks for the ZECpages viewing key Nov 7, 2023
@teor2345 teor2345 changed the title test: Scan the first 10 blocks for the ZECpages viewing key test: Scan the first 10 blocks with the ZECpages viewing key Nov 7, 2023
@teor2345 teor2345 changed the title test: Scan the first 10 blocks with the ZECpages viewing key test(scan): Scan the first 10 blocks with the ZECpages viewing key Nov 7, 2023
@mergify mergify bot closed this as completed in #7916 Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests S-needs-triage Status: A bug report needs triage
Projects
Zebra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

poc(scanner): add a populated state test for ZECpages viewing key ZcashFoundation/zebra
3 participants
@mpguerra @teor2345 @oxarbitrage