Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): Add keys to be scanned to Zebra config file #7941

Closed
1 task
Tracked by #7728
oxarbitrage opened this issue Nov 14, 2023 · 2 comments · Fixed by #7949
Closed
1 task
Tracked by #7728

feat(config): Add keys to be scanned to Zebra config file #7941

oxarbitrage opened this issue Nov 14, 2023 · 2 comments · Fixed by #7949
Assignees
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Nov 14, 2023

We want to add an array of keys to be scanned to the zebra config so we can add them to the key storage at startup.

The keys field can be a vector of tuples Vec<(String, Option<height>)> where the first argument is the viewing key as a string and height is an optional birth date. Or it can just be Vec<String> if we want to add the birth height later.

Tasks:

  • Add key list to zebra config. (New "scan" section)
@oxarbitrage oxarbitrage added S-blocked Status: Blocked on other tasks P-Medium ⚡ A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Nov 14, 2023
@teor2345
Copy link
Contributor

This is blocked on #7904 as the keys present in the config should be added to the storage at startup.

If we need to unblock this ticket, we can split connecting the keys up to storage into another PR or ticket. Totally up to you.

Tasks:

  • Add key list to zebra config. (New "scanner" section?)

I'd suggest scan, because most of our config names match the crate names

@oxarbitrage
Copy link
Contributor Author

I think you are right, i unblocked it, created #7946 which is blocked on this one and in #7904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions
Projects
Archived in project
2 participants