Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan verified blocks from sapling activation to the tip #7953

Closed
Tracked by #7728
teor2345 opened this issue Nov 16, 2023 · 2 comments · Fixed by #8040
Closed
Tracked by #7728

Scan verified blocks from sapling activation to the tip #7953

teor2345 opened this issue Nov 16, 2023 · 2 comments · Fixed by #8040
Assignees

Comments

@teor2345
Copy link
Contributor

teor2345 commented Nov 16, 2023

Motivation

We want to scan all the blocks in the state, this is the ticket for scanning verified blocks from sapling activation to the tip.

Suggested Design

Count from sapling activation height to LatestChainTip.best_tip_height(), ask the state for each block, then scan it. If there is no block for a height, wait 10 seconds, then try that height again in a loop.

Outside the state there is no distinction between finalised and non-finalised blocks, so this design will scan all of them.

Out of Scope

@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @arya2 @oxarbitrage @teor2345 @upbqdn

@arya2
Copy link
Contributor

arya2 commented Nov 17, 2023

I blocked closing this on #7947, but most of the changes can be made without it.

@arya2 arya2 assigned arya2 and unassigned arya2 Nov 24, 2023
@teor2345 teor2345 changed the title Scan previously verified blocks Scan previously verified blocks from block 1 to the tip Nov 28, 2023
@teor2345 teor2345 changed the title Scan previously verified blocks from block 1 to the tip Scan previously verified blocks from sapling activation to the tip Nov 28, 2023
@teor2345 teor2345 changed the title Scan previously verified blocks from sapling activation to the tip Scan verified blocks from sapling activation to the tip Nov 28, 2023
@mergify mergify bot closed this as completed in #8040 Dec 3, 2023
@teor2345 teor2345 self-assigned this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants