Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a v6 transaction format with no changes #7959

Open
Tracked by #7957
mpguerra opened this issue Nov 17, 2023 · 3 comments
Open
Tracked by #7957

Add a v6 transaction format with no changes #7959

mpguerra opened this issue Nov 17, 2023 · 3 comments
Labels
C-feature Category: New features NU-6 Network Upgrade: NU6 specific tasks
Milestone

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Nov 17, 2023

Motivation

A number of teams are working on the v6 transaction format for NU6 and they are looking to add this to Zebra.

The format should initially be the same as v5 transactions, and only valid when NU6 is activated.

@mpguerra mpguerra mentioned this issue Nov 17, 2023
3 tasks
@mpguerra mpguerra added P-Medium ⚡ NU-6 Network Upgrade: NU6 specific tasks C-feature Category: New features labels Nov 17, 2023
@mpguerra
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @arya2 @oxarbitrage @teor2345 @upbqdn

@teor2345 teor2345 changed the title Add v6 transactions Add a v6 transaction format with no changes Nov 19, 2023
@upbqdn
Copy link
Member

upbqdn commented Nov 20, 2023

Is the scope of this ticket limited to only adding a v6 enum variant to the Transaction enum without adding any further logic?

@teor2345
Copy link
Contributor

Is the scope of this ticket limited to only adding a v6 enum variant to the Transaction enum without adding any further logic?

It's important that v6 is only valid when NU6 is activated, otherwise we'd be breaking the NU5 consensus rules.

As another alternative, we could put all this code behind a feature.

@mpguerra mpguerra added this to the NU6 milestone Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: New features NU-6 Network Upgrade: NU6 specific tasks
Projects
Status: New
Development

No branches or pull requests

3 participants