Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a field for the network upgrade activation heights to TestnetParameters #7970

Closed
Tracked by #7845
arya2 opened this issue Nov 21, 2023 · 3 comments · Fixed by #8383
Closed
Tracked by #7845

Add a field for the network upgrade activation heights to TestnetParameters #7970

arya2 opened this issue Nov 21, 2023 · 3 comments · Fixed by #8383
Assignees
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-testing Category: These are tests I-usability Zebra is hard to understand or use

Comments

@arya2
Copy link
Contributor

arya2 commented Nov 21, 2023

Motivation

This field is needed for configuring custom testnet activation heights without hard-coded changes or compilation features.

Depends-On: #7968

It addresses part of item 2 in #8280:

First of all TESTNET_ACTIVATION_HEIGHTS[Nu5] constant is modified in network_upgrade.rs#L113 from 1_842_420 to 1_060_755. If there are plans to make this list a config rather than const or somehow use FAKE_TESTNET_ACTIVATION_HEIGHTS

Possible Design

Testing

Check that the parameters have not changed for Network::Mainnet or the default Testnet

@arya2 arya2 added A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement P-Medium ⚡ I-usability Zebra is hard to understand or use A-network Area: Network protocol updates or fixes NU-6 Network Upgrade: NU6 specific tasks C-testing Category: These are tests C-feature Category: New features labels Nov 21, 2023
@arya2 arya2 changed the title Add a field for the network upgrade activation heights to Add a field for the network upgrade activation heights to NetworkParameters Nov 21, 2023
@teor2345
Copy link
Contributor

I thought we were going to have a discussion about these tickets first?

@arya2
Copy link
Contributor Author

arya2 commented Nov 21, 2023

I thought we were going to have a discussion about these tickets first?

Yes, I forgot to link the discussion (#7967) in the tracking issue. There was an older comment asking for just this issue.

@teor2345 teor2345 removed C-enhancement Category: This is an improvement NU-6 Network Upgrade: NU6 specific tasks labels Nov 21, 2023
@teor2345
Copy link
Contributor

I don't think this is required for NU6 specifically?

@arya2 arya2 added S-blocked Status: Blocked on other tasks C-enhancement Category: This is an improvement and removed C-feature Category: New features labels Feb 26, 2024
@arya2 arya2 changed the title Add a field for the network upgrade activation heights to NetworkParameters Add a field for the network upgrade activation heights to TestnetParameters Feb 26, 2024
@mpguerra mpguerra added this to the Regtest milestone Mar 6, 2024
@arya2 arya2 removed the S-blocked Status: Blocked on other tasks label Apr 3, 2024
@mergify mergify bot closed this as completed in #8383 Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-testing Category: These are tests I-usability Zebra is hard to understand or use
Projects
Archived in project
3 participants