Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vietnam expressway shields #190

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Add Vietnam expressway shields #190

merged 2 commits into from
Feb 26, 2022

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Feb 23, 2022

Added a shield for expressways in Vietnam. The tagging scheme for Vietnamese route relations coalesced around the network=vn:* prefix too recently to be picked up by the tile server, but here’s how it’ll look:

CT.01

As in #141 (comment), I’m not sure putting CT. in the ref is quite correct, since no one would ever say or write “expressway CT.01”. But it does match what’s on the shield, so this is expedient for now. Even if there’s consensus to drop the CT. from ref, it might be desirable to drop the “CT.” from the map as a simplification anyways.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good!

@ZeLonewolf ZeLonewolf merged commit 7bd33f9 into main Feb 26, 2022
@ZeLonewolf ZeLonewolf deleted the 1ec5-vn-expy branch February 26, 2022 01:33
@1ec5 1ec5 mentioned this pull request Apr 25, 2022
This was referenced Jun 28, 2022
@ZeLonewolf
Copy link
Member

It appears that the standard we chose, network=vn:expressway, is no longer the one most commonly in use:
https://taginfo.openstreetmap.org/search?q=network%3Dvn%3Aexpressway#tags

@1ec5
Copy link
Member Author

1ec5 commented Aug 31, 2023

I discussed this back in February 2022 with ZioDragon, who at the time was the only mapper working on Vietnam’s national route and expressway relations. The network tags were all over the place, but I recall that they decided on vn:national and vn:expressway. To my surprise, last December, they unilaterally changed vn:expressway to VN:CT and then VN:Expressway, but now it’s inconsistent with national routes. I reached out to the OSM Vietnam Facebook group again for opinions. 🤞

@ZeLonewolf
Copy link
Member

Thanks for reaching out. If there is a change in local consensus on how to map Vietnam route relations, of course we should change our scheme to match whatever consensus emerges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants