feat: Created stepper input #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit bc02032): https://zeta-flutter-main--pr-67-stepper-input-09q89l3e.web.app (expires Wed, 15 May 2024 16:47:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6 |
thelukewalton
requested changes
May 8, 2024
| Widget stepperInputUseCase(BuildContext context) { | ||
| return WidgetbookTestWidget( | ||
| widget: ZetaStepperInput( | ||
| initialValue: context.knobs.intOrNull.input(label: 'Initial value'), |
There was a problem hiding this comment.
I think it would be better if this one were just int rather than intOrNull as it could be confusing in widgetbook
| final bool rounded; | ||
|
|
||
| /// The size of the stepper input. | ||
| final ZetaWidgetSize size; |
There was a problem hiding this comment.
I don't think we should use this enum if we aren't using all the values. Maybe we need an enum with just 2 sizes? or even just a boolean isLarge?
There was a problem hiding this comment.
I wanted to use an enum but didn't want to create a new one, but I can make one just for the stepper
thelukewalton
approved these changes
May 8, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.