Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support language #25

Closed
luckydonald opened this issue Dec 1, 2014 · 12 comments
Closed

Support language #25

luckydonald opened this issue Dec 1, 2014 · 12 comments

Comments

@luckydonald
Copy link

Under the Docs for v2 is an lang= Option.
It would be nice to see this implemented as something like this:

foo = forecastio.load_forecast(key, latitude, longitude, lang="en")

This was added to the API on 29 May 2014:
https://developer.forecast.io/docs/v2#options

Currently this is not working. Are there any quick workarounds?

@ZeevG
Copy link
Owner

ZeevG commented Dec 2, 2014

Not a bad idea, I will consider adding language support in the future.

Currently, a quick workaround is to use the manual forecast method https://github.com/ZeevG/python-forecast.io/blob/master/README.rst#function-forecastiomanualurl

So you would do something like this.

url = "https://api.forecast.io/forecast/API_KEY/-31.967819,115.87718?lang=es"
forecast = forecastio.manual(url)

@luckydonald
Copy link
Author

Thanks!
Thats a working workaround.

@ZeevG ZeevG closed this as completed Dec 5, 2014
@luckydonald
Copy link
Author

Not sure if this should be closed, until there is such function implemented?

@ZeevG
Copy link
Owner

ZeevG commented Dec 5, 2014

Good point, I'll reopen it.

I don't really want to add too many optional parameters to the load_forecast() function. In the future, I am thinking it might be better to handle supporting this (and all the other API options) through the design proposed in #26.

Let me know what your thoughts are.

@ZeevG ZeevG reopened this Dec 5, 2014
@luckydonald
Copy link
Author

Posted at #26 .

@suhajdab
Copy link

+1

5 similar comments
@dillenmeister
Copy link

+1

@MicheleCatalano
Copy link

+1

@sidorovit
Copy link

+1

@arhangel66
Copy link

+1

@DarkFox
Copy link

DarkFox commented Feb 8, 2018

+1

@ZeevG
Copy link
Owner

ZeevG commented Mar 17, 2018

Thanks for everyone's patience and apologies it took so long to add this feature. I've now released version 1.4.0 which allows you to specify a language.

@ZeevG ZeevG closed this as completed Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants