Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad public color on *.gv #3

Closed
grekon opened this issue Feb 4, 2012 · 1 comment
Closed

Bad public color on *.gv #3

grekon opened this issue Feb 4, 2012 · 1 comment

Comments

@grekon
Copy link

grekon commented Feb 4, 2012

Sometimes we have lines like this: "OnFilterScriptInit" [color="nan, nan, 1", shape=octagon];
Something wrong here:
auto time = node->info()->GetSelfTime();
auto ratio = static_cast(time) / static_cast(max_time);
// We encode color in HSB.
auto hsb = std::make_tuple(
(1.0 - ratio) * 0.6, // hue
(ratio * 0.9) + 0.1, // saturation
1.0 // brightness
);

temporary correct to:
auto ratio = 0;
if (max_time != 0)
ratio = static_cast(time) / static_cast(max_time);

because can't understand syntax of
graph.Traverse( [ &max_time, this, &graph ](const std::shared_ptr &node) {

Is it a unusual function call or function declaration? I see such thing at a the first time.

P.S. I have set gv font size from 10.8 to 20 for me, as at my huge gamemode the letters was undereadble.

@Zeex
Copy link
Owner

Zeex commented Jun 22, 2013

This seems outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants