Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Issue with "transitiontime" #8

Closed
dercaptainbc opened this issue Oct 27, 2019 · 6 comments
Closed

Issue with "transitiontime" #8

dercaptainbc opened this issue Oct 27, 2019 · 6 comments
Assignees
Labels
bug Something isn't working verify-fix Verify if the implemented fix has solved the issue

Comments

@dercaptainbc
Copy link

Hey, I've updated the adapter manulley to version 1.1.0 and unfortunately I realized that something goes wrong with transition time value. But its a little bit strange because, I've a script that changed color from green to blue with an 50 (5s) transition time. The initial color change works fine, but the second and third color change switched directly to the new color without any delay.

After downgrade to 1.0.2. (version that I had before) everthing works fine.

this time in english, so that you don't need to write a new comment ;-P

@dercaptainbc
Copy link
Author

dercaptainbc commented Oct 27, 2019

In the meantime I've changed the adapter into debug mode and found out the following thing..

inital color change

(460) Attempt 1x - Successfully set Hue play Rechts.
(460) Successfully set /lights/24/state/sat on Hue play Rechts (to 132).
(460) Successfully set /lights/24/state/hue on Hue play Rechts (to 28945).
(460) Successfully set /lights/24/state/transitiontime on Hue play Rechts (to 50).
(460) Attempt 1x - Send commands to Hue play Rechts (lights/24/state):{"hue":28945,"sat":132,"transitiontime":50}.

all other color changes

(460) Attempt 1x - Successfully set Hue play Rechts.
(460) Successfully set /lights/24/state/sat on Hue play Rechts (to 196).
(460) Successfully set /lights/24/state/hue on Hue play Rechts (to 40595).
(460) Attempt 1x - Send commands to Hue play Rechts (lights/24/state): {"hue":40595,"sat":196}.

@dercaptainbc
Copy link
Author

dercaptainbc commented Oct 27, 2019

any color change with version 1.0.2

(12372) Successfully set Hue play Rechts.
(12372) Successfully set /lights/24/state/sat on Hue play Rechts (to 196).
(12372) Successfully set /lights/24/state/hue on Hue play Rechts (to 40595).
(12372) Successfully set /lights/24/state/on on Hue play Rechts (to true).
(12372) Successfully set /lights/24/state/transitiontime on Hue play Rechts (to 50).

@Zefau
Copy link
Collaborator

Zefau commented Oct 27, 2019

I can confirm this and will fix it tomorrow.

This is because I added a function to verify if the command that is sent is actually different from current state (so no unnecessary commands are sent). I add an exception for transitiontime.

@Zefau Zefau self-assigned this Oct 28, 2019
@Zefau Zefau added the bug Something isn't working label Oct 28, 2019
@Zefau
Copy link
Collaborator

Zefau commented Oct 28, 2019

Could you test and verify if this issue got fixed with v1.1.2 (available on Github). Thanks

@Zefau Zefau added the verify-fix Verify if the implemented fix has solved the issue label Oct 28, 2019
@Zefau
Copy link
Collaborator

Zefau commented Oct 29, 2019

Now available on npm as well

@dercaptainbc
Copy link
Author

looks fine so far for me. Thanks a lot for the quick solution of the problem!

@Zefau Zefau closed this as completed Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verify-fix Verify if the implemented fix has solved the issue
Projects
None yet
Development

No branches or pull requests

2 participants