Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

States in popup window not correct #9

Closed
braindead1 opened this issue Mar 8, 2020 · 4 comments
Closed

States in popup window not correct #9

braindead1 opened this issue Mar 8, 2020 · 4 comments
Assignees
Labels
bug 🐛 Something isn't working

Comments

@braindead1
Copy link

braindead1 commented Mar 8, 2020

The state in the popup window does not fit to the state shown in the overview.

The following JSON is used in the devices JSON to create the state on the screenshot.

{
  "alarm_aktiviert": {
    "name": "Status",
    "function": "default",
    "states": {
      "activated": {
        "state": "alarm.0.status.activated"
      }
    },
    "jarvis": {
      "group": "alarm",
      "state": {
        "true": "aktiviert",
        "false": "deaktiviert"
      },
      "icon": "alarm-check"
    }
  }
}

state

@Zefau Zefau added the bug 🐛 Something isn't working label Mar 8, 2020
@Zefau Zefau self-assigned this Mar 8, 2020
@Zefau Zefau closed this as completed Mar 8, 2020
@Zefau
Copy link
Owner

Zefau commented Mar 8, 2020

Should be fixed with v0.0.3. Could you please test and verify? Thanks

@Zefau Zefau reopened this Mar 8, 2020
@braindead1
Copy link
Author

I installed v0.0.4 and the value of the state is correct now.

Regarding the name of the state ("default#activated" on the screenshot above) what is the correct way to "translate" it? Translations in jarvis.0.settings or is there another option I'm not aware of?

@Zefau
Copy link
Owner

Zefau commented Mar 9, 2020

Great it works.

Please find details regarding translations on the updated wiki page: https://github.com/Zefau/ioBroker.jarvis/wiki/Einstellungen#einstellung-translations

@Zefau Zefau closed this as completed Mar 9, 2020
@braindead1
Copy link
Author

braindead1 commented Mar 9, 2020

Although I understand your intention to implement translations, I assume that most users will only use one language. Besides that I think that there will be situations where a state name may have different translations depending on the device.

Instead of translating states in jarvis.0.settings it may be a good idea to implement the possibility to set the name (label) of the state in the state.

{
   "esszimmer_fenster":{
      "name":"Esszimmer",
      "room":"esszimmer",
      "function":"window",
      "states":{
         "open":{
            "state":"hm-rpc.1.XXXXXXXXXX.1.STATE",
            "label":"Status"
         }
      },
      "jarvis":{
         "group":"fenster_erdgeschoss"
      }
   }
}

@Zefau Zefau mentioned this issue Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants