Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix tests #7

Closed
wants to merge 2 commits into from
Closed

Feature/fix tests #7

wants to merge 2 commits into from

Conversation

nii236
Copy link

@nii236 nii236 commented Mar 28, 2022

The fuzz tests were overflowing the tests. This was prevented by adding some boundaries to the fuzzing.

Before:

image

After:

image

This pull request fixes only the tests in the ERC20StakingPool contract.

@nii236 nii236 closed this Mar 28, 2022
@nii236 nii236 deleted the feature/fix_tests branch March 28, 2022 07:35
@nii236 nii236 restored the feature/fix_tests branch March 28, 2022 08:09
@nii236 nii236 reopened this Mar 28, 2022
@devanoneth
Copy link
Contributor

FYI this PR didn't actually fix tests when I tried it on latest Foundry (forge 0.2.0 (20b2926 2022-06-10T00:17:56.047236Z)) but I opened #9 which does fix them.

@ZeframLou
Copy link
Owner

fixed by #9

@ZeframLou ZeframLou closed this Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants