New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish To-Do list project as per requirements #1
Conversation
- Create ./src files - Create HTML elements dynamically using JS - Style the list like the wireframe indicated - Add buttons, and cursor: pointer property to them :x! :x! y :x!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Zeraltz ,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, without a README file. Please ensure that all main headers from the README template should be present in your repo.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Invalid Code Review Request does not count into the code reviews limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Zeraltz, 👋
Highlights 👏
- The list structure is looking great, good job!
- List is created dynamically, perfect!
- Great work using the right GitHub Flow.
- Your README looks professional, well done!
- Commits are descriptive, good work.
- Linters are working properly, great job!
Your project is complete! There is nothing else to say other than... it's time to merge it! 🚀
Very nice work, congratulations! 🎉
APPROVED! 💯 💯 💯
Cheers and Happy coding! 🤓
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
✅ Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
#Project requirements
(<div> or <ul> element).
description [string].
completed [bool].
index: [number].
ALL REQUIREMENTS FULFILLED
Additions not required
cursor: pointer
property to buttons and checkboxes for better UX.