noElo modoption does nothing

[GoogleFrog]

See this game http://zero-k.info/Battles/Detail/466192?ShowWinners=True

[DeinFreund]

Could somebody check the database whether noelo was actually registered? I'd assume something already failed in the match setup leading to the value not being set.

[Histidine91]

Database doesn't store noElo state.

Server tries to read noElo state here before deciding whether to apply Elo effects. I am unable to find any indication that the value is actually written in the place the code looks.

[Sgathec]

Many, many months or even a year ago, noelo sometimes produced the intended result. Is it now guaranteed not to function? I haven't had it enabled for a long time.

[Anarchid]

Is this obsoleted by the post-hoc administration of what counts?

[sprunk]

No. Both players and admins have to take extra steps in addition to setting the modoption which are not necessary and many extra failure cases are created:

• players don't know they have to contact an admin for the modoption to actually work.
• players know but don't because of bystander.
• a player takes the responsibility but still fails to (disconnected, forgot...)
• admins are pinged but nobody tags the battle due to bystander.
• admins tag the battle without checking whether the battle really was noelo.

[DeinFreund]

Tags are set automatically, assuming noelo is properly sent to post battle processing.

[sprunk]

I did a check and the infra correctly processes noElo.

[Sgathec]

http://zero-k.info/Battles/Detail/600713
noelo=1 in a casual room, but casual ratings were changed after the battle.

[sprunk]

ZK (as in the game content itself) issue. ZeroK-RTS/Zero-K#3223

[GoogleFrog]

This is stupid. Read noElo from the modoptions directly upon game start. Springie sets the modoptions and it is written in the replay.

[GoogleFrog]

Exactly this: https://github.com/ZeroK-RTS/Zero-K-Infrastructure/pull/2519/files

[sprunk]

d4a1a38