Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize lagmonitor to deal with sharemode #1590

Closed
GoogleFrog opened this issue Nov 15, 2016 · 4 comments
Closed

Generalize lagmonitor to deal with sharemode #1590

GoogleFrog opened this issue Nov 15, 2016 · 4 comments
Labels

Comments

@GoogleFrog
Copy link
Contributor

I realized that lagmonitor does not know about team sharing at all. The gadget doesn't do anything when disabled so can be left in. Lagmonitor needs to be written in terms of players, not teams, for share mode to work correctly.

@sprunk
Copy link
Member

sprunk commented Dec 9, 2016

I realized that lagmonitor does not know about team sharing at all.

Is that from testing? Looking at the code it seems like it knows teams can have multiple players and should only tag a team AFK if all its players are AFK: https://github.com/ZeroK-RTS/Zero-K/blob/master/LuaRules/Gadgets/game_lagmonitor.lua#L302-L315

@GoogleFrog
Copy link
Contributor Author

No, there was no mention in the sharemode PR of lagmonitor so this is a ticket to do testing and make the required changes. Some change will be required because it is lagmonitor which must tell overdrive how many players are on an allyTeam and how many resources to give each team.

@sprunk
Copy link
Member

sprunk commented Dec 20, 2016

5d8902d
OD can now be told how many shares a team has (so far lagmonitor will only supply 0 or 1).

@sprunk
Copy link
Member

sprunk commented Jan 31, 2017

It is done.

@sprunk sprunk closed this as completed Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants