Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid hotkey XA causes Fight on asteroid maps #1819

Open
GoogleFrog opened this issue Jan 14, 2017 · 7 comments
Open

Grid hotkey XA causes Fight on asteroid maps #1819

GoogleFrog opened this issue Jan 14, 2017 · 7 comments

Comments

@GoogleFrog
Copy link
Contributor

The A should be eaten.

@sprunk sprunk changed the title Grid hotkey XA causes Fight on asteroid maps. Empty grid hotkey slots don't eat keypresses Jun 11, 2017
@sprunk
Copy link
Member

sprunk commented Jun 11, 2017

Grid hotkey XA causes Fight on asteroid maps.

@sprunk
Copy link
Member

sprunk commented Jun 11, 2017

This now also affects factories. For example factories with empty G slot can give a Guard order, same with F and force fire.

This is the most important with Hover which has no "weird raider" so allows to press S which cancels the order queue, something that does not happen with other facs.

As I understand, A is allowed for factories on purpose. Perhaps add an explicit attack command button there?

@GoogleFrog
Copy link
Contributor Author

'A' happens on purpose and as far as I recall the hotkeys are eaten in other cases.

@sprunk
Copy link
Member

sprunk commented Jun 12, 2017

As far as I can see there is no special exception for A so not sure why ther others wouldn't work (they do for me).

@GoogleFrog GoogleFrog changed the title Empty grid hotkey slots don't eat keypresses Grid hotkey XA causes Fight on asteroid maps Jul 7, 2023
@GoogleFrog
Copy link
Contributor Author

The title is the title.

  • XW on any map -> Hotkey is eaten rather than selecting the area mex with terraform command (W).
  • XA on second campaign mission -> Hotkey is eaten rather than selecting Fight (Wind is not unlocked).
  • XA on Astroturf -> Fight is selected.
  • G with Tank Factory selected -> Guard is selected. This one seems fine as it is using the same mechanism as A selecting Fight.

So the problem is specifically that XA selects Fight on asteroid maps. The difference between asteroid maps and the campaign is that wind is greyed out, not removed. So it is probably to do with that.

@sprunk
Copy link
Member

sprunk commented Jul 8, 2023

G with Tank Factory selected -> Guard is selected. This one seems fine as it is using the same mechanism as A selecting Fight.

My earlier remarks are from a time before Bolas so it was possible to ruin the rally queue on Hoverfac by pressing S for Stop, which I think was pretty bad. But even without that particular failure mode I don't think it's entirely fine (though not pressing either, all of these are individually mild):

  • it's inconsistent, sometimes G is guard and sometimes it is a unit.
  • some facs don't have a H unit, which toggles hold position. This can be pretty hard to notice.
  • guard and holdpos aren't too bad but customizable hotkeys mean you can get all sorts of inconvenient orders, in particular Stop which ruins the queue, in the holes.
  • modders can create fac rosters that have the S slot free.

@GoogleFrog
Copy link
Contributor Author

Sure. But that seems like a different ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants