Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for automatic pause/unpause behavior when using menus #3073

Closed
Histidine91 opened this issue May 20, 2018 · 3 comments
Closed

Plan for automatic pause/unpause behavior when using menus #3073

Histidine91 opened this issue May 20, 2018 · 3 comments

Comments

@Histidine91
Copy link
Member

Histidine91 commented May 20, 2018

Thread: http://zero-k.info/Forum/Thread/25342

The posts there suggest that anything that opens F10 or F11 menu should pause, but nothing should unpause except a specific Pause keypress.

However, I am 99.999% sure that if we do that, someone will get stuck in the paused state after using the menu and not know how to unpause, despite the big (but mostly transparent) pause message in the center of the screen.

Ideas?

@sprunk
Copy link
Member

sprunk commented May 20, 2018

The way I read the post it's fine if closing the menu unpauses in general as long as it's not unpaused after a save (even if the menu gets closed meanwhile).

@Histidine91
Copy link
Member Author

c6ebd95: pauses when save/load menu is opened, and adds a separate option for auto-unpause on menu close (default on). This satisfies both Renthrak and Brackman's needs.

I think this could be closed for now? Reopen if further configuration is needed, or there are any other widgets that open their own menus but do not pause.

@sprunk
Copy link
Member

sprunk commented May 26, 2018

Looks good

@sprunk sprunk closed this as completed May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants