Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why Steel_Blue had broken F1 view before BAR engine #3677

Open
GoogleFrog opened this issue Jul 31, 2019 · 10 comments
Open

Investigate why Steel_Blue had broken F1 view before BAR engine #3677

GoogleFrog opened this issue Jul 31, 2019 · 10 comments

Comments

@GoogleFrog
Copy link
Contributor

https://i.imgur.com/oeuUcbi.jpg

@lhog
Copy link
Contributor

lhog commented Jul 31, 2019

Looks like something else along the line of #3620 and #3669

It's puzzling to see that so many cases popped up since recently. The bugs were there forever, but only started to pop up after some ZK or engine change. Frankly I have no idea what change might have caused that. Anyway SteelBlue will need to follow a tedious path of finding the offending widget: http://zero-k.info/Forum/Thread/28600

@SteelBlueZK
Copy link
Contributor

SteelBlueZK commented Jul 31, 2019

my testimony:

At the start of the game I see only red(when heightmap is active). After some condition is met, the colors change to what they should be. The condition is the ground changing height, or being affected. for example, rouge misiles or merlin misiles deform ground, so when their attacks impact I get heightmap over the explosion area. a mex explosion also does that. Larget buildings, like factories/singus, update underneath their footprint, and smaller buildings, like LLt/picket do not. These rules follow line of sight, so I need to see the modified terrain before I get heightmap.

I also have a video https://streamable.com/og2fl https://www.youtube.com/watch?v=VU0DqTU0I5g

Placeholder seems to adjust terrain too.

ZeroK-RTS/CrashReports#23239

I certainly didn't notice it before, but there's a sliver of color on the North edge of the map.


thinking it's an engine bug, Ihog has guided me to do engine launches in a strange way.
https://media.discordapp.net/attachments/278908415756206080/606195914914267158/unknown.png?width=711&height=623
https://media.discordapp.net/attachments/278908415756206080/606196443501428765/unknown.png?width=690&height=623

engine 104.0.1-1318-g8cf4dea works and
engine 104.0.1-1322-gd3b03b5 is bork

@SteelBlueZK
Copy link
Contributor

SteelBlueZK commented Aug 7, 2019

I did not realise that the engine updates happened already. Still have issue https://streamable.com/s1lj2
engine 104.0.1-1333-gce618bd

ZeroK-RTS/CrashReports#23412 this is the infodump of the session I played with the video,just in case.

@SteelBlueZK
Copy link
Contributor

Bar engine does not have broken F1 view. recommend close.

@lhog
Copy link
Contributor

lhog commented Feb 8, 2022

Check you have no PBO disabled, something like UsePBO=0 in your infolog/springsettings.
The thing is I wasn't fixing anything in this regard. Either PBO is disabled or it got fixed "accidentally"

@lhog
Copy link
Contributor

lhog commented Feb 8, 2022

N2S. Two likely suspects:

beyond-all-reason/spring@6ef7975
beyond-all-reason/spring@6b5abe6

@sprunk sprunk changed the title Steel_Blue has broken F1 view Investigate why Steel_Blue had broken F1 view before BAR engine Feb 8, 2022
@SteelBlueZK
Copy link
Contributor

SteelBlueZK commented Feb 9, 2022

UsePBO = 0

in steamapps\common\Zero-K\_springsettings.cfg
Also in springsettings.cfg
I don't know why there's underscore springsettings and just springsettings.

@lhog
Copy link
Contributor

lhog commented Feb 9, 2022

No idea too, but you can see the actually used value in infolog.txt. 99% sure it's going to be UsePBO = 0.
It would likely take 20 min to fix the bug if I had AMD GPU at hand, but otherwise I can only go by educated guesswork, so I'm not sure how to proceed. if you want to help the fellow AMD folks hit me up on Discord (ivand) and I can make a few aforementioned educated guesses and send binaries to you for testing, otherwise UsePBO = 0 is fine by me for now.

@SteelBlueZK
Copy link
Contributor

[t=00:00:02.310272][f=-000001] SetSettings Value, UsePBO, 1
SetSettings Value, UsePBO, 0 appears 6 times.
Looks like UsePBO = 0 is aggresively set so that changing the value in springsettings.cfg didn't change my game.
ZeroK-RTS/CrashReports#55273

Screenshot from my end showing my view is right. https://cdn.discordapp.com/attachments/432874986064052235/941698428793151488/unknown.png

@GoogleFrog
Copy link
Contributor Author

I think compat mode sets pbo to 0. Alternately you could disable springsettings changes under the developer tab http://zero-k.info/mediawiki/Zero-K:Developing#Modifying_the_game

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants