Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: simplify base Transformer, move Transformer's __init__ and fit to MethodTF #192

Merged
merged 2 commits into from Sep 9, 2021

Conversation

Zeroto521
Copy link
Owner

FeatureUnion also need Transformer's inverse_transform, but other attrs and methods are extra.

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #192 (c422577) into master (78781e6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files          20       20              
  Lines         460      457       -3     
  Branches       49       49              
==========================================
- Hits          457      454       -3     
  Misses          1        1              
  Partials        2        2              
Impacted Files Coverage Δ
dtoolkit/transformer/base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78781e6...c422577. Read the comment docs.

@Zeroto521 Zeroto521 merged commit 274170b into master Sep 9, 2021
@Zeroto521 Zeroto521 deleted the SK-TF branch September 9, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant