MAINT: transform series to dataframe #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this could force series input type transform to dataframe type
MethodTF's transform and inverse_transform could receive array-like data type.
decorator now couldn't validate all conditions.
decorator now couldn't validate all conditions.
Zeroto521
commented
Sep 18, 2021
|
|
||
| @wraps(func) | ||
| def decorator(self, X): | ||
| X_new = func(self, X) |
There was a problem hiding this comment.
Why does there remove the decorator?
This line code couldn't handle all considerations.
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
=======================================
Coverage 99.36% 99.37%
=======================================
Files 22 22
Lines 472 479 +7
Branches 49 50 +1
=======================================
+ Hits 469 476 +7
Misses 1 1
Partials 2 2
Continue to review full report at Codecov.
|
series would show data type
…a-toolkit into series_to_frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transformandinverse_transformrequire 2d data.But the input would be 1d data (series).
To handle this, there have made the output data from series to dataframe.
1d data uses dataframe is a little bit weird.
Now we transform data type when data come in.