Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHN: let top_n default return is index not tuple #248

Merged
merged 2 commits into from Oct 26, 2021
Merged

Conversation

Zeroto521
Copy link
Owner

@Zeroto521 Zeroto521 commented Oct 26, 2021

simplify data structure, the tuple is hard to deal.

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #248 (4f3dbf2) into master (9e0a0a7) will decrease coverage by 0.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   99.61%   98.65%   -0.97%     
==========================================
  Files          21       21              
  Lines         520      520              
  Branches       55       55              
==========================================
- Hits          518      513       -5     
- Misses          0        3       +3     
- Partials        2        4       +2     
Impacted Files Coverage Δ
dtoolkit/accessor/dataframe.py 96.15% <ø> (-1.29%) ⬇️
dtoolkit/accessor/_util.py 80.00% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0a0a7...4f3dbf2. Read the comment docs.

@Zeroto521 Zeroto521 merged commit 999c81d into master Oct 26, 2021
@Zeroto521 Zeroto521 deleted the topn-patch branch October 26, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant