Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: call method Series.get_attr via function name is ok #398

Merged
merged 3 commits into from Jan 8, 2022

Conversation

Zeroto521
Copy link
Owner

Prefer to call Series.getattr() rather then Series.get_attr(), but the function name is get_attr. It would be a little weird.
So call Series.getattr() is ok, but not recommended.

@Zeroto521 Zeroto521 changed the title MAINT: keep the calling method of function name using, Series.get_attr MAINT: call method Series.get_attr via function name is ok Jan 8, 2022
@Zeroto521 Zeroto521 enabled auto-merge (squash) January 8, 2022 11:06
@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #398 (c8c2c82) into master (39d4d50) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          23       23           
  Lines         550      551    +1     
  Branches       74       74           
=======================================
+ Hits          549      550    +1     
  Partials        1        1           
Impacted Files Coverage Δ
dtoolkit/accessor/series.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d4d50...c8c2c82. Read the comment docs.

@Zeroto521 Zeroto521 added this to the 0.0.9 milestone Jan 8, 2022
@Zeroto521 Zeroto521 merged commit 8421fa2 into master Jan 8, 2022
@Zeroto521 Zeroto521 deleted the also-keep-the-functaion-name branch January 8, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant