Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHN: FeatureUnion would merge all into one DataFrame and the index would use the common part #433

Merged
merged 4 commits into from Jan 22, 2022

Conversation

Zeroto521
Copy link
Owner

Two or more Series/DataFrame data merge, should consider the index.

The indexes are the same that would be fine.
The indexes aren't different that would have a few problems.

The reindex method isn't right if the index has meaningful it could be ID.
And stack them as ndarray, that would be pitiful.

@Zeroto521 Zeroto521 added this to the 0.0.11 milestone Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #433 (e83f969) into main (99ec54f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   99.81%   99.81%   -0.01%     
==========================================
  Files          23       23              
  Lines         550      549       -1     
  Branches       74       73       -1     
==========================================
- Hits          549      548       -1     
  Partials        1        1              
Impacted Files Coverage Δ
dtoolkit/transformer/sklearn.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ec54f...e83f969. Read the comment docs.

@Zeroto521 Zeroto521 marked this pull request as ready for review January 22, 2022 01:59
@Zeroto521 Zeroto521 enabled auto-merge (squash) January 22, 2022 01:59
@Zeroto521 Zeroto521 merged commit ec20030 into main Jan 22, 2022
@Zeroto521 Zeroto521 deleted the feature-union branch January 22, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: feature_union can't concat different dataframe well
1 participant