Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Drop unique_counts, use pandas.DataFrame.nunique instead #502

Merged
merged 7 commits into from Apr 15, 2022

Conversation

Zeroto521
Copy link
Owner

pandas.DataFrame.nunique already did this.

  • closes #xxxx
  • whatsnew entry

Please `pandas.DataFrame.nunique` instand
@Zeroto521 Zeroto521 changed the title DEP: Drop unique_counts DEP: Drop unique_counts, use pandas.DataFrame.nunique instead Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #502 (a03c2c2) into main (9d71bb3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #502   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          60       60           
  Lines         834      836    +2     
  Branches       93       92    -1     
=======================================
+ Hits          831      833    +2     
  Misses          1        1           
  Partials        2        2           
Impacted Files Coverage Δ
dtoolkit/accessor/dataframe/unique_counts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d71bb3...a03c2c2. Read the comment docs.

@Zeroto521 Zeroto521 enabled auto-merge (squash) April 15, 2022 05:45
@Zeroto521 Zeroto521 merged commit b1ab4a3 into main Apr 15, 2022
@Zeroto521 Zeroto521 deleted the drop-unique_counts branch April 15, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant