Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Simplify the documentation of reverse_geocode + update result #636

Merged
merged 4 commits into from Aug 8, 2022

Conversation

Zeroto521
Copy link
Owner

@Zeroto521 Zeroto521 commented Aug 8, 2022

update example

044     ...         ],
045     ...     )
046     ...     .from_wkt(drop=True, crs=4326)
047     ...     .to_frame("geometry")
048     ... )
049     >>> df
050                          geometry
051     0  POINT (-71.05949 42.35847)
052     1  POINT (-77.03653 38.89773)
053     >>> df.reverse_geocode()
Differences (unified diff with -expected +actual):
    @@ -1,3 +1,3 @@
                          geometry                                            address
     0  POINT (-71.05977 42.35860)  18-32, Tremont Street, 02108, Tremont Street, ...
    -1  POINT (-77.03655 38.89772)  Pennsylvania Avenue Northwest, 20500, Pennsylv...
    +1  POINT (-77.03655 38.89772)  1600, Pennsylvania Avenue Northwest, 20500, Pe...

@Zeroto521 Zeroto521 enabled auto-merge (squash) August 8, 2022 03:13
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #636 (9359118) into main (2f8d6b1) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
- Coverage   99.48%   99.31%   -0.17%     
==========================================
  Files          99       99              
  Lines        1157     1162       +5     
  Branches      110      110              
==========================================
+ Hits         1151     1154       +3     
- Misses          2        3       +1     
- Partials        4        5       +1     
Impacted Files Coverage Δ
...oolkit/geoaccessor/geodataframe/reverse_geocode.py 100.00% <100.00%> (ø)
dtoolkit/geoaccessor/geoseries/reverse_geocode.py 100.00% <100.00%> (ø)
dtoolkit/transformer/sklearn/OneHotEncoder.py 92.30% <0.00%> (-7.70%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Zeroto521 Zeroto521 merged commit 85110c2 into main Aug 8, 2022
@Zeroto521 Zeroto521 deleted the accessor/geocode/example branch August 8, 2022 03:26
@Zeroto521 Zeroto521 added this to the 0.0.17 milestone Aug 13, 2022
geometry address
0 POINT (-71.05977 42.35860) 18-32, Tremont Street, 02108, Tremont Street, ...
1 POINT (-77.03655 38.89772) Pennsylvania Avenue Northwest, 20500, Pennsylv...
1 POINT (-77.03655 38.89772) 1600, Pennsylvania Avenue Northwest, 20500, Pe...
Copy link
Owner Author

@Zeroto521 Zeroto521 Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result of reverse_geocode was changed.
Same problem at #733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant