Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Depcrated utm_crs #637

Merged
merged 3 commits into from Aug 8, 2022
Merged

DEP: Depcrated utm_crs #637

merged 3 commits into from Aug 8, 2022

Conversation

Zeroto521
Copy link
Owner

@Zeroto521 Zeroto521 commented Aug 8, 2022

  • closes #xxxx
  • whatsnew entry

pyproj.database.query_utm_crs_info too slow to query all data.
For 1 point will cost 200ms but for 2000 points will cost 200s.
Even try parallelize to utm_crs, but the speed is still so lower.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #637 (bb89de8) into main (d94df6c) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   99.48%   99.31%   -0.17%     
==========================================
  Files         101      101              
  Lines        1172     1174       +2     
  Branches      110      110              
==========================================
  Hits         1166     1166              
- Misses          2        3       +1     
- Partials        4        5       +1     
Impacted Files Coverage Δ
dtoolkit/geoaccessor/geoseries/utm_crs.py 100.00% <100.00%> (ø)
dtoolkit/transformer/sklearn/OneHotEncoder.py 92.30% <0.00%> (-7.70%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Zeroto521 Zeroto521 enabled auto-merge (squash) August 8, 2022 07:12
@Zeroto521 Zeroto521 merged commit b871d6f into main Aug 8, 2022
@Zeroto521 Zeroto521 deleted the depcrated-utm_crs branch August 8, 2022 07:15
@Zeroto521 Zeroto521 mentioned this pull request Aug 10, 2022
2 tasks
@Zeroto521 Zeroto521 added this to the 0.0.17 milestone Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant