Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: New geoaccessor Index.h3 #811

Merged
merged 55 commits into from Dec 23, 2022
Merged

ENH: New geoaccessor Index.h3 #811

merged 55 commits into from Dec 23, 2022

Conversation

Zeroto521
Copy link
Owner

@Zeroto521 Zeroto521 commented Dec 20, 2022

Think about how to apply h3 accessor to DataFrame.
DataFrame accessor always needs to key in a column name. But using the index could avoid inputting.
So Index accessor h3 as the base, then adapt that to Series and DataFrame.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #811 (c4d71c8) into main (7f61846) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   99.69%   99.70%           
=======================================
  Files         142      145    +3     
  Lines        1984     2030   +46     
  Branches      429      445   +16     
=======================================
+ Hits         1978     2024   +46     
  Misses          1        1           
  Partials        5        5           
Impacted Files Coverage Δ
dtoolkit/geoaccessor/geoseries/to_h3.py 100.00% <100.00%> (ø)
dtoolkit/geoaccessor/index/__init__.py 100.00% <100.00%> (ø)
dtoolkit/geoaccessor/index/h3.py 100.00% <100.00%> (ø)
dtoolkit/geoaccessor/index/is_h3.py 100.00% <100.00%> (ø)
dtoolkit/geoaccessor/series/h3.py 100.00% <100.00%> (ø)
dtoolkit/geoaccessor/series/is_h3.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Zeroto521 Zeroto521 added this to the 0.0.20 milestone Dec 22, 2022
@Zeroto521 Zeroto521 enabled auto-merge (squash) December 23, 2022 04:41
@Zeroto521 Zeroto521 merged commit cf40a05 into main Dec 23, 2022
@Zeroto521 Zeroto521 deleted the geoaccessor/h3 branch December 23, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant